-
-
Notifications
You must be signed in to change notification settings - Fork 603
refine routing context #1170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refine routing context #1170
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||||||
PR Type
Enhancement
Description
Add
AddDialogsmethod to routing context interfaceRefactor dialog management for better consistency
Improve logging format in observers
Minor code cleanup and variable renaming
Diagram Walkthrough
File Walkthrough
IRoutingContext.cs
Add AddDialogs method to interfacesrc/Infrastructure/BotSharp.Abstraction/Routing/IRoutingContext.cs
AddDialogsmethod to interface for appending dialog listsConversationObserver.cs
Refactor observer with improved loggingsrc/Infrastructure/BotSharp.Core/MessageHub/Observers/ConversationObserver.cs
routeCtxtoroutingCtxAddDialogsmethod callRoutingContext.cs
Implement AddDialogs with defensive copyingsrc/Infrastructure/BotSharp.Core/Routing/RoutingContext.cs
AddDialogsmethod for appending dialog collectionsSetDialogsto create defensive copiesGetDialogsto return defensive copiesRoutingService.InvokeAgent.cs
Use AddDialogs for message handlingsrc/Infrastructure/BotSharp.Core/Routing/RoutingService.InvokeAgent.cs
Context.SetDialogscalls withContext.AddDialogsFileInstructService.SelectFile.cs
Rename routing context variablesrc/Infrastructure/BotSharp.Core/Files/Services/Instruct/FileInstructService.SelectFile.cs
routeContexttoroutingCtxfor consistencyChatHubObserver.cs
Add import and improve loggingsrc/Plugins/BotSharp.Plugin.ChatHub/Observers/ChatHubObserver.cs
BotSharp.Core.MessageHub.ObserversMySqlService.cs
Reorder using statementssrc/Plugins/BotSharp.Plugin.ExcelHandler/Services/MySqlService.cs
ExcelHandlerSettings.cs
Add documentation commentsrc/Plugins/BotSharp.Plugin.ExcelHandler/Settings/ExcelHandlerSettings.cs