-
-
Notifications
You must be signed in to change notification settings - Fork 603
refine side car states #1089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refine side car states #1089
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
PR Type
Bug fix, Enhancement
Description
Fix sidecar state restoration bug in
SetCurrentStatemethodAdd state inheritance options for sidecar conversations
Introduce
SideCarOptionsmodel for configuration controlEnhance
SendMessagemethod with optional parametersChanges diagram
Changes walkthrough 📝
IConversationSideCar.cs
Update interface with SideCarOptions parametersrc/Infrastructure/BotSharp.Abstraction/SideCar/IConversationSideCar.cs
SideCarOptionsparameter toSendMessagemethodSideCar.ModelsnamespaceSideCarOptions.cs
Add SideCarOptions configuration modelsrc/Infrastructure/BotSharp.Abstraction/SideCar/Models/SideCarOptions.cs
SideCarOptionsclassIsInheritStatesandInheritStateKeyspropertiesEmpty()factory methodBotSharpConversationSideCar.cs
Implement state inheritance and restoration logicsrc/Infrastructure/BotSharp.Core.SideCar/Services/BotSharpConversationSideCar.cs
_sideCarOptionsfield for configuration storageRestoreStatesmethod with inheritance logicSendMessageto accept and store optionsUsing.cs
Add SideCar models namespace importsrc/Infrastructure/BotSharp.Core.SideCar/Using.cs
BotSharp.Abstraction.SideCar.ModelsConversationStateService.cs
Fix SetCurrentState parameter bugsrc/Infrastructure/BotSharp.Core/Conversations/Services/ConversationStateService.cs
SetCurrentStatemethod parameter usage_curStates.Valuestostate.Values