Conversation
🦋 Changeset detectedLatest commit: 1ac0fab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Linux Benchmarks for 09745c3
|
Contributor
Linux Benchmarks for bb15cd3
|
Contributor
Linux Benchmarks for 1caa912
|
Contributor
Linux Benchmarks for e60e252
|
styfle
reviewed
May 9, 2023
| ` | ||
|
|
||
| for (const shell of [Bash, Fish, PowerShell, Zsh]) { | ||
| describe(shell, () => { |
There was a problem hiding this comment.
Nit pick: you can use describe.each() here to loop instead
styfle
approved these changes
May 9, 2023
Contributor
Linux Benchmarks for 6f163c9
|
Contributor
Linux Benchmarks for 1e08246
|
Contributor
Linux Benchmarks for 768aca2
|
Contributor
Linux Benchmarks for 13ea39a
|
Contributor
Linux Benchmarks for 8ad05a1
|
Contributor
Linux Benchmarks for 12eb4ba
|
Contributor
Linux Benchmarks for 1ac0fab
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as corepack becomes more and more mainstream, we need to make sure it's nice to use it with fnm.
it's still experimental so it's not happening automatically, but it's easy to set up now.
cc @styfle who nerd-sniped me
fixes #566
(fixes #390 because it is required for this to land)