feat: support fnm install --latest#859
Conversation
🦋 Changeset detectedLatest commit: 3e06839 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fnm install --latest
Schniz
left a comment
There was a problem hiding this comment.
Can you please run pnpm generate-command-docs to update the commands.md file?
I also had a small suggestion for the error message.
other than that,
I wonder if we can add a test for it somehow. Given that the version is dynamic it might be problematic, but maybe just a smoke test with no expectations other than "not fail"?
src/commands/install.rs
Outdated
| #[error("Can't find latest version")] | ||
| CantFindLatest, |
There was a problem hiding this comment.
I wonder if we should be more explicit about the issue, like: "can't find any versions in the upstream version index"
There was a problem hiding this comment.
resolved, thx for suggestion
|
Also, thank you very much for stepping in and contributing! can you run |
Thx for suggestion, i have added smoke test and run |
|
The commands file is not up to date because of the version change :( can you rerun the script? |
done |
92d49a8 to
d17a74f
Compare
sorry, one more question. Do i need to bump version manually ? |
d17a74f to
3924dc0
Compare
3924dc0 to
3432ec7
Compare
3432ec7 to
5c5c76f
Compare
docs/commands.md
Outdated
|
|
||
| ``` | ||
| fnm 1.32.0 | ||
| fnm 1.31.1 |
There was a problem hiding this comment.
I don’t understand why this is not updated, if you’re rebased from main and ran the script. Maybe something is funky there and I’ll fix it?
There was a problem hiding this comment.
I think it's updated rn after i run it one more time.
5c5c76f to
cc9e00f
Compare
cc9e00f to
5c5c76f
Compare
5c5c76f to
b384755
Compare
As this is a new feature
|
Amazing! Thank you so much. |
|
@Schniz Pls approve one more time, seems there are some inconsistency on the usage of node package mangager (pnpm vs yarn) which caused the workflow just fail. I have aligned all workflow to use pnpm, and added command to install pnpm in ci script as well. See
|
3d35347 to
9a053a7
Compare
Because GitHub actions approval button is missing
This reverts commit f5f2ca2. we can revert the yarn changes and do it in a different PR
This should help to support install the latest node version using
fnm install --latestJust as #797 expected.