Fix --resolve-engines in combination with --use-on-cd#1259
Merged
Schniz merged 4 commits intoSchniz:masterfrom Oct 6, 2024
Merged
Fix --resolve-engines in combination with --use-on-cd#1259Schniz merged 4 commits intoSchniz:masterfrom
--resolve-engines in combination with --use-on-cd#1259Schniz merged 4 commits intoSchniz:masterfrom
Conversation
🦋 Changeset detectedLatest commit: 856b5cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2c902ea to
183a47f
Compare
Owner
|
oh damn i didn't see this PR and I committed #1263 with some tests. let me attribute you in that PR |
Owner
|
i love your code more, i'll just add my tests to this PR 😁 |
Merged
Contributor
Author
|
Thanks for merging this. So I believe on Windows with CMD it still missing the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shell output was not checking for the package.json file.
Fixes #1100