Skip to content

Update README.md#1224

Merged
Schniz merged 1 commit intoSchniz:masterfrom
MrSrv7:master
Oct 6, 2024
Merged

Update README.md#1224
Schniz merged 1 commit intoSchniz:masterfrom
MrSrv7:master

Conversation

@MrSrv7
Copy link
Contributor

@MrSrv7 MrSrv7 commented Aug 12, 2024

I got an error while trying to use a specific node version with fnm. Upon debugging, I found that 'power-shell' has been updated to "powershell".

image

@MrSrv7
Update README.md
2be7d83 
'power-shell' has been updated to "powershell".
@changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2024

⚠️ No Changeset found

Latest commit: 2be7d83

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fnm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 6:37am

@mo8it mo8it mentioned this pull request Aug 12, 2024
Closed
@mo8it
Copy link
Contributor

mo8it commented Aug 12, 2024

This is caused by my PR #1222 and I just used the value that was in the help message. I fixed the docs in #1225

@MrSrv7 MrSrv7 closed this Aug 16, 2024
@mo8it
Copy link
Contributor

mo8it commented Aug 16, 2024

Why did you close it?

@MrSrv7
Copy link
Contributor Author

MrSrv7 commented Aug 16, 2024

Hey! I didn't see your PR #1225, so I raised it. Since you already raised it, it doesn't make sense to raise a PR just for the same changes, right? It will just be redundant.

@mo8it
Copy link
Contributor

mo8it commented Aug 16, 2024

They aren't the same. You change the README, I (try to) change the docs.

@MrSrv7
Copy link
Contributor Author

MrSrv7 commented Aug 19, 2024

Oh okay! My bad, I didn't check the PR properly. Let me reopen

@MrSrv7 MrSrv7 reopened this Aug 19, 2024
@Schniz Schniz merged commit 2d9a9dd into Schniz:master Oct 6, 2024
@Schniz
Copy link
Owner

Schniz commented Oct 6, 2024

this was incorrect but i'm pushing a fix

@Schniz Schniz mentioned this pull request Oct 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mo8it mo8it mo8it approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MrSrv7 @mo8it @Schniz