Skip to content

This $PATH should be wrapped in quotes so it will work with spaces#1066

Merged
Schniz merged 3 commits intoSchniz:masterfrom
floh1695:master
May 27, 2024
Merged

This $PATH should be wrapped in quotes so it will work with spaces#1066
Schniz merged 3 commits intoSchniz:masterfrom
floh1695:master

Conversation

@floh1695
Copy link
Contributor

This $PATH use needs to be wrapped in quotes so it will expand properly if there are spaces within the $PATH. This seems to only effect sh, not bash.

To reproduce:

  1. Run PATH="space path:$PATH"
  2. Run eval $(fnm env)
  3. At this point I would expect you to get the error: sh: 1: export: path:rest/off/you/path/before/next/space: bad variable name

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2023

🦋 Changeset detected

Latest commit: 7698cc4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
fnm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@floh1695
Copy link
Contributor Author

The the fails for clippy and bench/linux don't seem related to what I changed. Please let me know if I'm mistaken about that.

@Schniz
Copy link
Owner

Schniz commented Oct 30, 2023

Yeah that’s fine. I will also accept a cargo clippy —fix PR or will try doing it today. Mind pushing a changeset so it’ll appear on the changelog? (Check out the comment by the bot for help)

@Schniz
Copy link
Owner

Schniz commented Oct 30, 2023

And thanks for contributing! I don’t take this lightly

@floh1695
Copy link
Contributor Author

I have pushed up a patch changeset. Is that correct or should I have made it a minor change?

And no worries, thanks for providing such a great tool!

@Schniz
Copy link
Owner

Schniz commented Oct 30, 2023

Patch is good! Thank you

@vercel
Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fnm ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 1:31pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants