Skip to content

[claude-code-settings] Update Claude Code settings permissionRule#5338

Closed
plmrry wants to merge 10 commits intoSchemaStore:masterfrom
plmrry:update-claude-code-permission-rule
Closed

[claude-code-settings] Update Claude Code settings permissionRule#5338
plmrry wants to merge 10 commits intoSchemaStore:masterfrom
plmrry:update-claude-code-permission-rule

Conversation

@plmrry
Copy link
Copy Markdown

@plmrry plmrry commented Feb 3, 2026

Summary

Updates the pattern of the permissionRule def in claude-code-settings.json

The current claude-code-settings.ts is a bit outdated. Claude now supports things like MCPSearch and LSP, and TodoWrite is no longer a tool`

Schema Details

See ## Tools available to Claude in this file:

https://code.claude.com/docs/en/settings.md

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2026

Thanks for the PR!

This section of the codebase is owned by @domdomegg and @bogini - if they write a comment saying "LGTM" then it will be merged.

Copy link
Copy Markdown
Contributor

@domdomegg domdomegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for this PR. I work on Claude Code at Anthropic so can help with accuracy here.

A couple of things:

  1. MCPSearch should be ToolSearch — the internal tool name (what the permission system matches against) is ToolSearch, not MCPSearch. Our user-facing docs call it MCPSearch which is confusing, but permission rules match on the actual tool .name property. A rule like MCPSearch would never match anything.

  2. Missing TaskStop — this is the tool that stops background tasks/shells. KillShell is just a backwards-compat alias for TaskStop, so both should be in the pattern.

  3. Merge conflict — this PR conflicts with master now (master got LS, MultiEdit, NotebookRead, SlashCommand from another PR). The combined, corrected pattern should be:

^((Bash|Edit|ExitPlanMode|Glob|Grep|KillShell|LS|LSP|MultiEdit|NotebookEdit|NotebookRead|Read|Skill|SlashCommand|Task|TaskCreate|TaskGet|TaskList|TaskOutput|TaskStop|TaskUpdate|TodoWrite|ToolSearch|WebFetch|WebSearch|Write)(\\((?=.*[^)*?])[^)]+\\))?|mcp__.*)$

And in the test file, MCPSearch should be ToolSearch too.

@plmrry
Copy link
Copy Markdown
Author

plmrry commented Feb 12, 2026

@domdomegg Whoops — thanks for clarifying! (and updating!)

@plmrry plmrry closed this Feb 12, 2026
@plmrry plmrry deleted the update-claude-code-permission-rule branch February 12, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants