fix(pytest): add support for tool.pytest.ini_options#5146
Merged
hyperupcall merged 1 commit intoSchemaStore:masterfrom Nov 20, 2025
Merged
fix(pytest): add support for tool.pytest.ini_options#5146hyperupcall merged 1 commit intoSchemaStore:masterfrom
hyperupcall merged 1 commit intoSchemaStore:masterfrom
Conversation
Change additionalProperties from false to true in the LegacyConfig definition to allow pytest's ini_options to accept plugin-specific configuration options. This ensures that tool.pytest.ini_options properly validates configurations with additional properties from pytest plugins, matching the behavior of the modern Config format (pytest >=9) which already has additionalProperties: true.
Contributor
|
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for
tool.pytest.ini_optionswhich is the official pytest configuration method inpyproject.tomlsince pytest 6.0+ (2020).Problem
The schema currently rejects
ini_optionsin the LegacyConfig format (line 35 hadadditionalProperties: false), causing validation errors in tools like tombi-lint when running in strict mode, even though the configuration is valid and documented by pytest.Error message users receive:
Solution
Changed
additionalProperties: falsetoadditionalProperties: trueon line 35 in the LegacyConfig definition, allowingini_optionsand other pytest configuration keys.Testing
Impact
This affects any project using:
Related