Skip to content

support '.patch' versions in the 'api-version' field#3824

Merged
github-actions[bot] merged 2 commits intoSchemaStore:masterfrom
Machine-Maker:fix/paper-plugins
May 29, 2024
Merged

support '.patch' versions in the 'api-version' field#3824
github-actions[bot] merged 2 commits intoSchemaStore:masterfrom
Machine-Maker:fix/paper-plugins

Conversation

@Machine-Maker
Copy link
Copy Markdown
Contributor

the api-version field now supports an optional 3rd number

@github-actions
Copy link
Copy Markdown
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@Machine-Maker
Copy link
Copy Markdown
Contributor Author

I see that some CODEOWNERS stuff is setup. I'm on the dev team for PaperMC (which uses this paper plugin schema). Is there some system for getting ownership of this template?

@hyperupcall
Copy link
Copy Markdown
Member

@Machine-Maker Yes! You can just add a section with your name to .github/CODEOWNERS. Once you add your username (or other usernames of other developers on the same team), we have a GitHub workflow that will mention you when a pull request modifies the files (that you specify in CODEOWNERS). You can then reply "LGTM", and the same bot will merge the PR, so long as CI passes.

@github-actions github-actions bot merged commit f85f852 into SchemaStore:master May 29, 2024
@github-actions
Copy link
Copy Markdown
Contributor

Merging because @hyperupcall is a code-owner of all the changes - thanks!

@hyperupcall
Copy link
Copy Markdown
Member

hyperupcall commented May 29, 2024

I should probably send a patch for the bot so it doesn't merge when LGTM is in quotes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants