[STORY-2259] Improve collaborator list to include is_limited #1126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collaborators/list.go
Outdated
| t.Header([]string{"Email", "Username", "Status", "Is Limited"}) | ||
|
|
||
| t.Append([]string{scapp.Owner.Email, scapp.Owner.Username, CollaboratorOwner}) | ||
| _ = t.Append([]string{scapp.Owner.Email, scapp.Owner.Username, CollaboratorOwner, "false"}) |
Contributor
Author
There was a problem hiding this comment.
ℹ️ For some reason the CI complained and wanted me to handle the errors.
Contributor
There was a problem hiding this comment.
No worries, our CI checks the lint on the diff with the master only.
So the old calls to Append either use an old version of the library that doesn't return an error, or were implemented before our CI checked for this kind of lint problem.
SCedricThomas
approved these changes
Jul 16, 2025
collaborators/list.go
Outdated
| t.Header([]string{"Email", "Username", "Status", "Is Limited"}) | ||
|
|
||
| t.Append([]string{scapp.Owner.Email, scapp.Owner.Username, CollaboratorOwner}) | ||
| _ = t.Append([]string{scapp.Owner.Email, scapp.Owner.Username, CollaboratorOwner, "false"}) |
Contributor
There was a problem hiding this comment.
No worries, our CI checks the lint on the diff with the master only.
So the old calls to Append either use an old version of the library that doesn't return an error, or were implemented before our CI checked for this kind of lint problem.
SCedricThomas
approved these changes
Jul 16, 2025
Contributor
SCedricThomas
left a comment
There was a problem hiding this comment.
Looks better this way. Good job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First iteration.
Second iteration.
