[STORY-2189] Warn user before unscheduling periodic backups #1121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo-scalingo
reviewed
Jul 3, 2025
leo-scalingo
approved these changes
Jul 4, 2025
Member
leo-scalingo
left a comment
There was a problem hiding this comment.
After our conversation, actually LGTM
sc-david-voisin
approved these changes
Jul 10, 2025
243fc32 to
9eef5be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STORY-2189
This story implements a new check to warn a user before unscheduling periodic backups. The user will now be prompted to confirm, or the command will fail.
I found this function that is used elsewhere to do the same thing.
Here are things that were done as well:
BoolPtrfunctionaskContinueto be more genericState of the QA: