Fix model reordering in Constrained Fitting widget#3857
Merged
Conversation
krzywon
approved these changes
Feb 3, 2026
Contributor
krzywon
left a comment
There was a problem hiding this comment.
Tested and this seems to fix the drag/drop issue
Contributor
|
@wpotrzebowski - please give this a review when you are able. |
Contributor
wpotrzebowski
left a comment
There was a problem hiding this comment.
It seems to work as expected. No error has been thrown while trying to rearrange the table. I've managed, however to drag model name e.g. M3 to the data explorer. I think this may be a seprate issue though`
Contributor
|
Contributor
|
Shouldn't be that merged against release-6.1.3 (instead of main) |
Contributor
I've been cherry-picking changes not directly made to the release branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
self.model().flags(index)returns a Qt ItemFlag/ItemFlags object, which cannot be passed to int() — that caused the TypeError. Testing the flag viaflags & QtCore.Qt.ItemIsDropEnabledand converting to bool avoids the error and is the correct bitmask check.Fixes #3856
How Has This Been Tested?
Local win11 test
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)