Conversation
rozyczko
approved these changes
Jan 30, 2026
Member
rozyczko
left a comment
There was a problem hiding this comment.
Thanks for fixing this! Another leftover from the Fitting widget refactoring exercise...
Code looks good, functionality indeed is fixed.
Contributor
Author
|
Thanks for the review @rozyczko, I'll wait until my colleague who raised this is happy before merging. |
jellybean2004
approved these changes
Jan 30, 2026
Member
jellybean2004
left a comment
There was a problem hiding this comment.
Fiddled around with the UI; it seems to work as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the bug introduced in SasView 6.1.0 where orientation parameters were not available in the polydispersity tab when the 2D view checkbox was checked. In SasView 6.1.x, only volume parameters were available regardless of the state of the 2D view checkbox.
How Has This Been Tested?
Using a cylinder model I checked and unchecked the polydispersity and 2d view checkboxes and found that the orientation parameters appear/disappear from the polydispersity tab as expected.
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)