point to the correct logic#3843
Merged
krzywon merged 1 commit intorelease-6.1.3from Feb 17, 2026
Merged
Conversation
krzywon
approved these changes
Jan 23, 2026
Contributor
krzywon
left a comment
There was a problem hiding this comment.
It looks like this corrects the issue and the code looks fine. I'll wait to merge this in case others want time to take a look.
Contributor
|
The failing CIs are not using the release requirements files, which is the cause of the failure. As long as the pull request CIs are successful, this can be merged. |
Contributor
|
@gnsmith has agreed to review the functionality of this PR, but that review will likely have to wait a couple of weeks. This will likely be the last PR before a final release candidate for v6.1.3. |
gnsmith
approved these changes
Feb 17, 2026
gnsmith
left a comment
There was a problem hiding this comment.
This change restores the missing functionality (polydispersity was unavailable in batch fitting and now is again).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fitting widget refactor caused yet another issue. Addressed.
Fixes #3783
How Has This Been Tested?
Local Win10 tests
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)