3815: Fix for project load breaking the replace fit button#3816
Merged
Conversation
…on is created to ensure the trigger is active on project loading
gonzalezma
approved these changes
Dec 12, 2025
Contributor
gonzalezma
left a comment
There was a problem hiding this comment.
Tested functionality in Windows 11 and works as expected.
Contributor
Author
|
As discussed at our meeting today, this will need a code review before merging. @rozyczko, would you be able to give a check at some point? |
rozyczko
approved these changes
Dec 17, 2025
Member
rozyczko
left a comment
There was a problem hiding this comment.
The PR correctly removes the duplicate connection from contextMenu(), leaving only the connection in createSendToMenu() where it logically belongs.
Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On line 303 of
sas.qtgui.MainWindow.DataExplorer,initPerspectives()is called as part of the project load process. Init perspectives destroys existing perspectives and creates fresh ones. This initialization also creates a new sub-menu for the send to button. While the menu is replaced, the trigger action is not renewed on the new menu item, so no connection is made. I've moved the connection into the method that creates the action to ensure any new actions created are linked properly.Fixes #3815
How Has This Been Tested?
Locally, tested loading a project and made sure the replace option replaces data in a fit tab.
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)