Fixing name for dispersity parameter for multishell modells#3779
Merged
Fixing name for dispersity parameter for multishell modells#3779
Conversation
Member
|
I have not had a chance to test this but my first question would be how this might affect saved experiment files using a multishell model? |
krzywon
approved these changes
Dec 3, 2025
Contributor
krzywon
left a comment
There was a problem hiding this comment.
In previous versions, attempting to modify the PD params for a shell value threw errors. This PR fixes that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
onPolyComboIndexChange takes the parameter name as thickness[n] instead of the correct value, e.g. for shell 2 this should be thickness2, such that sasmodels can handle it. A fix needs to ensures to pass on an expanded parameter name like thickness2 to kernel_module.set_dispersion instead of the thickness[n] which triggered the ValueError.
Fixes #3741
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)