Skip to content

Adds logger error for unsuitably scaled axes#3778

Merged
DrPaulSharp merged 1 commit intomainfrom
data-operation
Nov 17, 2025
Merged

Adds logger error for unsuitably scaled axes#3778
DrPaulSharp merged 1 commit intomainfrom
data-operation

Conversation

@DrPaulSharp
Copy link
Copy Markdown
Contributor

Description

When data is supplied that cannot be plotted on a set of axes with a particular scale (e.g., zero/negative data on log axes), we raise an error in the logger and suggest to the user to change the scale of the axes. This applies to general 1D plots, going beyond where the issue was originally discovered in the Data Operation tool.

Fixes #3762, #3767

How Has This Been Tested?

The test in #3762 now returns a logger error rather than a ValueError. The default log scale is retained for plots of data.

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)
    • Wheels installer (GH artifact) has been tested (installed and worked)

Licensing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

Copy link
Copy Markdown
Contributor

@Cristian2299 Cristian2299 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything it's working as expected. Tested with the installer on windows 10.

@DrPaulSharp DrPaulSharp merged commit 71ad6ba into main Nov 17, 2025
30 checks passed
@DrPaulSharp DrPaulSharp deleted the data-operation branch November 17, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error appearing when generate output dataset containing all zero intensity values in "Data Operation" window

2 participants