Revert the polydisp table to the original state on model change#3768
Merged
wpotrzebowski merged 1 commit intomainfrom Nov 17, 2025
Merged
Revert the polydisp table to the original state on model change#3768wpotrzebowski merged 1 commit intomainfrom
wpotrzebowski merged 1 commit intomainfrom
Conversation
This was referenced Nov 15, 2025
Contributor
|
Tested functionality (for polydispersity) in Windows 11 and works as expected. |
gonzalezma
approved these changes
Nov 17, 2025
Contributor
gonzalezma
left a comment
There was a problem hiding this comment.
Code looks ok to me and fixes bug (at least for polydispersity, but I don't see why it would be different for the magnetic part)
wpotrzebowski
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Running a fit with polydisperse parameters checked adds an error column to the polydisp table.
This is OK when just running the fit - the min/max/npts/nsigs/function combobox columns get shifted and display ok.
But when a model is changed AFTER the fitting, the table is not properly reindexed.
THis PR fixes the issue.
Fixes # 3536
How Has This Been Tested?
Local win 10 testing
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)