Fixes for quick plotting - both 1D and 3D#3749
Merged
Conversation
…//github.com/SasView/sasview into 3746-quick-plotting-from-data-explorer-fails
| # Disable rotation for large sets. | ||
| # TODO: Define "large" for a dataset | ||
| SET_TOO_LARGE = 500 | ||
| if len(data_x) > SET_TOO_LARGE: |
Contributor
There was a problem hiding this comment.
I guess in majority (or even all cases) data_x is same/similar to data_y but wondering if this conditions shouldn't be generalized for data.size
Member
Author
There was a problem hiding this comment.
It could. I'd like to look at this method in a bit more detail, so postponing fixing it here (as this is just a big fix commit) but will create a new issue.
wpotrzebowski
approved these changes
Nov 12, 2025
Contributor
wpotrzebowski
left a comment
There was a problem hiding this comment.
Tested on Mac. Works as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3747 #3746
How Has This Been Tested?
Local tests on Win10
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)