Skip to content

Clean up some nitpicks - dead file removal#3735

Merged
llimeht merged 6 commits intoSasView:mainfrom
llimeht:tmp/nits
Nov 11, 2025
Merged

Clean up some nitpicks - dead file removal#3735
llimeht merged 6 commits intoSasView:mainfrom
llimeht:tmp/nits

Conversation

@llimeht
Copy link
Copy Markdown
Contributor

@llimeht llimeht commented Nov 11, 2025

Description

This PR:

  • deletes some unused and files that should never have been in git
  • fixes a typo in a logging string
  • removes sphinx from the runtime deps since it is no longer used

How Has This Been Tested?

CI, running relevant bits of code

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)
    • Wheels installer (GH artifact) has been tested (installed and worked)

Licensing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@llimeht llimeht requested a review from DrPaulSharp November 11, 2025 10:24
Copy link
Copy Markdown
Contributor

@DrPaulSharp DrPaulSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, just one thing to consider.

Comment thread .gitignore
@llimeht llimeht merged commit 501b388 into SasView:main Nov 11, 2025
15 checks passed
@llimeht llimeht deleted the tmp/nits branch November 11, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants