Prevent crashes and log errors if docs can't be found.#3689
Merged
llimeht merged 3 commits intoSasView:mainfrom Nov 7, 2025
Merged
Prevent crashes and log errors if docs can't be found.#3689llimeht merged 3 commits intoSasView:mainfrom
llimeht merged 3 commits intoSasView:mainfrom
Conversation
Render the documentation system inactive rather than crashing when the docs can't be located
DrPaulSharp
approved these changes
Nov 7, 2025
Contributor
DrPaulSharp
left a comment
There was a problem hiding this comment.
This works as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Calculating the location of the docs at runtime can generate exceptions if the docs can't be found. They should never not be found, of course, ... but....
Given that development environments are probably the most likely to have this broken and contributor camp is looming, this is a quick and urgent fix to make sure that new contributors don't end up yak-shaving their development environment more than needed.
The commits here:
_tutorialLocationmember that would lead to a crash on startupHow Has This Been Tested?
sas/system/user.pyor by deleting them (fromdist-packages/sasif you are working in an editable install as recommended)Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)