Fix bumps constrained fit#3375
Merged
krzywon merged 3 commits intorelease-6.1.0from May 13, 2025
Merged
Conversation
krzywon
reviewed
May 12, 2025
Contributor
krzywon
left a comment
There was a problem hiding this comment.
This allows constrained fits to run again, but logger warnings are now triggered on line 360 of BumpsFitting.py complaining the slot object for constrained parameters are no longer uncertainty objects. A quick debug says they are now bumps.parameter.Variable objects.
Contributor
Author
|
Ah, so this doesn't fix the problem. |
krzywon
approved these changes
May 13, 2025
Contributor
krzywon
left a comment
There was a problem hiding this comment.
Coupled with the latest change to bumps, constrained fits now run. Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows running constrained fits with new bumps version >= 1.0.0b6
Fixes #3370
How Has This Been Tested?
Ran a test constraint fit with the fix, and it works without the error described in #3370
NOTE: the convergence plot doesn't seem to work when running a consrtrained fit, which is I think a different issue.
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licencing (untick if necessary)