Skip to content

Removing macOS-13 from the regular build#3181

Merged
wpotrzebowski merged 1 commit intomainfrom
3134-macos-build-simultaneous-notarization-causing-timeouts
Jan 22, 2025
Merged

Removing macOS-13 from the regular build#3181
wpotrzebowski merged 1 commit intomainfrom
3134-macos-build-simultaneous-notarization-causing-timeouts

Conversation

@wpotrzebowski
Copy link
Copy Markdown
Contributor

@wpotrzebowski wpotrzebowski commented Jan 13, 2025

Description

As decided at the contributor camp in Lund, we will only build macos-latest in the regular builds and the macOS-13 only for the release.

Fixes # (issue/issues)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@wpotrzebowski wpotrzebowski linked an issue Jan 13, 2025 that may be closed by this pull request
@wpotrzebowski wpotrzebowski marked this pull request as ready for review January 13, 2025 20:57
@butlerpd butlerpd added the Discuss At The Call Issues to be discussed at the fortnightly call label Jan 13, 2025
Copy link
Copy Markdown
Contributor

@krzywon krzywon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would argue this doesn't fully fix the issue, since the macos-13 build is never trigged for releases, so the issue should remain open for now. This does, however, solve the more immediate issue of the notarization clashes, so I think this can be merged.

@butlerpd
Copy link
Copy Markdown
Member

So we should unlink the issue from this PR so that it doesn't close automatically? Otherwise it looks like we can merge this now?

@wpotrzebowski wpotrzebowski merged commit eccc0fd into main Jan 22, 2025
@wpotrzebowski wpotrzebowski deleted the 3134-macos-build-simultaneous-notarization-causing-timeouts branch January 22, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Discuss At The Call Issues to be discussed at the fortnightly call

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MacOS Build: Simultaneous Notarization Causing Timeouts

3 participants