Fitting widget refactor#3169
Merged
jamescrake-merani merged 7 commits intomainfrom Mar 3, 2025
Merged
Conversation
updated for ver. 6.0 release source and with PR raised issues addressed.
Member
Author
|
macos-latest fails due to a know issue with binary signing. #3134 |
Contributor
|
@rozyczko - there's conflicts to resolve |
krzywon
reviewed
Jan 10, 2025
krzywon
approved these changes
Jan 30, 2025
Contributor
krzywon
left a comment
There was a problem hiding this comment.
I think this is ready now. Please note - let's hold off on merging this until we know the branching scheme for v6.1.0 release.
This was referenced Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the refactoring effort, the same as in #2651 but reparented to the current
main.All issues raised by @krzywon in the original PR have been addressed.
Additionally, the files involved in the refactor were "improved" by
ruff(runningruff check)This is part 1 of the refactoring, focused on the two biggest and most independent components.
Next, I will attempt to refactor out constraints to a separate module.
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licencing (untick if necessary)