3109: Bumps v1.* compatibility fix#3165
Merged
jamescrake-merani merged 5 commits intomainfrom Mar 13, 2025
Merged
Conversation
…ject to allow bumps fits to proceed
jamescrake-merani
approved these changes
Mar 13, 2025
Contributor
jamescrake-merani
left a comment
There was a problem hiding this comment.
Code looks fine to me, and works on my machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This circumvents the fitting issue related to the recent changes in the
bumpspackage that require parameter values to be floats, where SasView has been usinguncertantiesobjects. TheParameterobject has an optional attribute calledslotintroduced in v1.* that I am using here instead. This attribute does not exist in v0.9.3 of bumps, but the way I am using it creates a new attribute of the parameter, maintaining backward compatibility.Fixes #3109
Fixes #3227
How Has This Been Tested?
Tested locally using both bumps v0.9.3 and v1.0.0a10. Fits (and subsequent fits in the same tab) are successful for both versions of bumps.
Review Checklist:
Documentation (check at least one)
Installers
Licencing (untick if necessary)