Fix strange alpha behaviour in cutout mode.#98
Merged
Santarh merged 1 commit intoSantarh:masterfrom Jul 7, 2020
emilianavt:master
Merged
Fix strange alpha behaviour in cutout mode.#98Santarh merged 1 commit intoSantarh:masterfrom emilianavt:master
Santarh merged 1 commit intoSantarh:masterfrom
emilianavt:master
Conversation
Owner
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I am working on a face tracking application that captures the scene including the alpha channel. During this, I noticed some strange interactions with MToon's cutout mode:
This very simple patch fixes both issues. Setting the alpha to 1.0 after
clipshould be fine. Pixels are already discarded if they are below the threshold. Otherwise, it should be safe to assume that they should be considered opaque. If blending should take place, the first line in the followingifdefblock resets the alpha anyways.