Add Type field to AttributeAttribute#393
Merged
SamboyCoding merged 3 commits intoSamboyCoding:developmentfrom Dec 13, 2024
Merged
Add Type field to AttributeAttribute#393SamboyCoding merged 3 commits intoSamboyCoding:developmentfrom
SamboyCoding merged 3 commits intoSamboyCoding:developmentfrom
Conversation
Pull Request Test Coverage Report for Build 12320749043Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Owner
|
This cannot be merged until https://github.com/BepInEx/Il2CppInterop/blob/9d4599dc78d69ede49a2ee96a1ccf41eec02db5b/Il2CppInterop.Generator/Passes/Pass70GenerateProperties.cs#L46 is changed and the change has time to be taken up by consumers. |
Contributor
Author
|
I added the name field back, so that this can be merged without breaking Il2CppInterop. |
SamboyCoding
approved these changes
Dec 13, 2024
This was referenced Dec 13, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intention is for the Name field to be removed after Il2CppInterop switches to using the Type field.