Skip to content

Conversation

@PiyushRaj927
Copy link
Collaborator

@PiyushRaj927 PiyushRaj927 commented Jun 3, 2023

Fixes #9

  1. Installed the necessary build dependency.
  2. Downloaded hyperloglog v2.17 from https://github.com/citusdata/postgresql-hll and built it.
  3. Installed hyperloglog.
  4. Cleaned up the build dependencies.
  5. Added POSTGRES_HLL_VERSION as an argument in the Makefile.
  6. Added hll to share_preload_libraries.
  7. Updated the smoke test for hyperloglog.

Testing

I have test the images locally and have found no issues

Signed-off-by: Piyush Raj <piyushraj92739@gmail.com>
@PiyushRaj927 PiyushRaj927 marked this pull request as ready for review June 9, 2023 08:25
@PiyushRaj927
Copy link
Collaborator Author

@jayanth-kumar-morem, would you mind reviewing this when you have a chance?

Copy link
Collaborator

@jayanth-kumar-morem jayanth-kumar-morem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jayanth-kumar-morem
Copy link
Collaborator

Hey @PiyushRaj927 , The code looks clean. GHA are failing due to some postgis version ig. Can you pin your forked repo passing GHA for this PR, so that we can merge it.

@PiyushRaj927
Copy link
Collaborator Author

PiyushRaj927 commented Jun 10, 2023

Hi @jayanth-kumar-morem, I have merged the version patches, and all the GitHub Actions are passing successfully.

@jayanth-kumar-morem jayanth-kumar-morem merged commit 1ed1a48 into Samagra-Development:main Jun 10, 2023
@PiyushRaj927 PiyushRaj927 deleted the add_hll branch June 10, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HyperLogLog

2 participants