Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the codebase by moving several model types from the core-invoice crate into the foundation crate, making them more broadly accessible across the project.
Changes:
- Moved core model types (
CompanyInformation,HexColor,MonthHalf,PostalAddress,Rate,StreetAddress) fromcore-invoicetofoundation - Added
InvalidHexColorerror variant toModelErrorin the foundation crate - Updated import statements and type aliases across affected crates to reflect the new module locations
Reviewed changes
Copilot reviewed 14 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
crates/foundation/src/models/model_error.rs |
Added InvalidHexColor error variant to support moved HexColor model |
crates/foundation/src/models/mod.rs |
Added module declarations and public exports for newly moved models |
crates/foundation/src/lib.rs |
Updated public API exports to include the moved model types |
crates/foundation/src/models/snapshots/*.snap |
Added snapshot test files for MonthHalf display tests |
crates/core-invoice/src/models/mod.rs |
Updated imports to reference moved models from foundation crate |
crates/core-invoice/src/models/error.rs |
Added error conversion case for InvalidHexColor |
crates/core-invoice/src/models/data/submodels/mod.rs |
Removed module declarations for moved models |
crates/core-invoice/src/models/data/submodels/month_half.rs |
Updated imports to use foundation's ModelError instead of local Error |
crates/core-invoice/src/models/data/submodels/hex_color.rs |
Updated imports and error types to use foundation's types |
crates/core-invoice/src/models/data/submodels/snapshots/*.snap |
Removed snapshot test files (moved to foundation) |
crates/cli/src/main.rs |
Updated imports and added type alias NamedInvoicePdf for clarity |
crates/cli/src/dispatch_command.rs |
Updated function signatures to use NamedInvoicePdf type alias |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
- Coverage 96.88% 96.84% -0.05%
==========================================
Files 102 102
Lines 2217 2218 +1
==========================================
Hits 2148 2148
- Misses 69 70 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.