Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where email sending failed for non-Gmail SMTP servers and improves logging related to email encryption passwords.
Changes:
- Fixed SMTP authentication to use full email address instead of just username, enabling support for non-Gmail servers
- Made error handling consistent by removing logging from error constructor functions (logging happens at boundaries)
- Added informative logging when encryption password is read from environment variable
- Improved logging messages around email sending operations
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/core-invoice/src/models/error.rs | Removed internal logging from aes_decryption_failed error constructor to align with codebase patterns |
| crates/core-invoice/src/models/data/submodels/email/lettre_bridge.rs | Fixed SMTP credentials to use full email address instead of username-only, enabling non-Gmail SMTP servers |
| crates/core-invoice/src/logic/send_email.rs | Updated comment to reflect generic SMTP server support instead of Gmail-specific |
| crates/cli/src/input/tui/helpers/build_password.rs | Added info log when encryption password is read from environment variable |
| crates/cli/src/dispatch_command.rs | Enhanced email sending logging with clearer progress messages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
- Coverage 95.06% 95.06% -0.01%
==========================================
Files 101 101
Lines 2208 2207 -1
==========================================
- Hits 2099 2098 -1
Misses 109 109 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug where sending of email fails if domain is not
@gmail.com.Improved log messages if wrong encryption password was used
Logging that encryption password prompt was skipped if the value was read from environment variable