Conversation
Co-authored-by: Sajjon <864410+Sajjon@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix misleading log message for email setup
Fix misleading warning when email settings are missing on Feb 22, 2026
klirr invoice --email
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
=======================================
Coverage 95.06% 95.06%
=======================================
Files 101 101
Lines 2208 2208
=======================================
Hits 2099 2099
Misses 109 109 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
klirr invoice --emailwithout email settings initialized, the warning incorrectly pointed users toklirr data initinstead ofklirr email init, since both data and email files live under the same data directory.Changes
run.rs: AddedEMAIL_INIT_HINTconstant andhas_missing_email_setup_data()which checks specifically for theemail.ronfile path. Updatedlog_data_setup_hint_or_errorto match email-missing errors first, showing the correct hint before falling through to the generic data-missing check.main.rs: Re-exportedemail_settings_pathfromklirr_core_invoiceto make it available inrun.rs.Before:
After:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.