Skip to content

Fix cargo package verification failure caused by cross-crate include_str!#34

Merged
Sajjon merged 3 commits intomainfrom
copilot/fix-test-typ-file-issue
Feb 21, 2026
Merged

Fix cargo package verification failure caused by cross-crate include_str!#34
Sajjon merged 3 commits intomainfrom
copilot/fix-test-typ-file-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 21, 2026

  • Investigate CI failure (include_str! points outside crate directory)
  • Add TYPST_LAYOUT_TEST public constant to klirr-foundation crate (using local include_str!)
  • Export the constant from klirr-foundation/src/lib.rs
  • Update klirr-core-invoice/src/models/layout.rs to use the constant from klirr-foundation
  • Verify build succeeds (cargo build)
  • Verify cargo package succeeds for klirr-core-invoice
  • All tests pass
  • Run cargo fmt
Original prompt

Do a PR fixing:

https://github.com/Sajjon/klirr/actions/runs/22259881492/job/64396511230#step:10:1

No worries if that test.typ file need be duplicated. It is very small. But try first without duplication


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…oundation

Co-authored-by: Sajjon <864410+Sajjon@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issue with test.typ file in CI workflow Fix cargo package verification failure caused by cross-crate include_str! Feb 21, 2026
Copilot AI requested a review from Sajjon February 21, 2026 16:40
Copy link
Copy Markdown
Owner

@Sajjon Sajjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Sajjon Sajjon marked this pull request as ready for review February 21, 2026 18:07
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.03%. Comparing base (6602bcb) to head (1477442).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files         101      101           
  Lines        2176     2176           
=======================================
  Hits         2068     2068           
  Misses        108      108           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sajjon
Copy link
Copy Markdown
Owner

Sajjon commented Feb 21, 2026

@copilot run cargo fmt and commit

Co-authored-by: Sajjon <864410+Sajjon@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Feb 21, 2026

@copilot run cargo fmt and commit

Done — committed in 1477442.

Copilot AI requested a review from Sajjon February 21, 2026 18:20
@Sajjon Sajjon merged commit 5d1b225 into main Feb 21, 2026
7 checks passed
@Sajjon Sajjon deleted the copilot/fix-test-typ-file-issue branch February 21, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants