Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=======================================
Coverage 96.90% 96.90%
=======================================
Files 76 76
Lines 1648 1650 +2
=======================================
+ Hits 1597 1599 +2
Misses 51 51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
Add support for Homebrew prebuilt binaries by extending CI workflows to build, release, and publish macOS (Apple Silicon) and Linux artifacts without requiring local Rust installation.
- Introduce a reusable
setup-sccacheaction for caching Rust compilation - Update release workflow to generate, package, and upload binaries, then update Homebrew formula
- Rename and refactor release steps into
create-release,build-and-upload, andupdate-homebrewjobs
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/test.yml | Added Setup sccache steps before Rust toolchain installs |
| .github/workflows/release.yml | Refactored release flow: added sccache, split release jobs, asset build, and Homebrew update |
| .github/actions/setup-sccache/action.yml | New composite action to install, configure, and cache sccache |
Comments suppressed due to low confidence (3)
.github/workflows/release.yml:51
- The indentation of
create-release:does not match other job definitions underjobs:. Please align it with the same indent level as other job entries to avoid YAML parsing errors.
create-release:
.github/workflows/test.yml:32
- [nitpick] For consistency with the existing
Set up Ruststep, consider renaming this step toSet up sccache(two words) to match the verb-noun pattern.
- name: Setup sccache
.github/workflows/test.yml:32
- [nitpick] The
setup-sccachestep is duplicated across multiple workflows; you could DRY this by using workflow templates, composite actions, or YAML anchors to reduce repetition.
- name: Setup sccache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for homebrew but without the need for users to have Rust installed thanks to prebuilt binaries for macOS (Apple Silicon support only, Intel is being phased out) and Linux.
Publishing formula updates to https://github.com/Sajjon/homebrew-klirr