Conversation
Closed
Contributor
|
Looks great, @xni7! Test code above works with no edits on my end. Going to think a little bit about workflow details for the charts we want to re-use across multiple domains. At the very least, I think we should be able to share the init functions across domains in many cases. Would be nice to avoid the duplication of the chart YAML as well, but will need to think about that (and maybe update safetyGraphics). |
jwildfire
approved these changes
Oct 19, 2021
Contributor
|
@xni7 This is working great! I set this up to use the same init functions as the My test code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #81
Summary
This is based on the hard coded prototype , formalized into the {safetyCharts} pkg structure
metaecgand mappingsTest Code