Skip to content

docs: remove type hints from docstrings#94

Merged
lars-reimann merged 1 commit intomainfrom
40-remove-type-hints-from-parameters-results-in-docstrings
Apr 23, 2024
Merged

docs: remove type hints from docstrings#94
lars-reimann merged 1 commit intomainfrom
40-remove-type-hints-from-parameters-results-in-docstrings

Conversation

@lars-reimann
Copy link
Copy Markdown
Member

@lars-reimann lars-reimann commented Apr 23, 2024

Closes #40

Summary of Changes

We've had a few cases in the past where type hints in the docs and in the code disagreed. Unfortunately, PyCharm prefers the types in the docs in this case, leading to confusion. Now, only the code contains type hints.

@lars-reimann lars-reimann requested a review from a team as a code owner April 23, 2024 16:37
@lars-reimann lars-reimann linked an issue Apr 23, 2024 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 8 0 0 0.75s
✅ PYTHON mypy 8 0 2.42s
✅ PYTHON ruff 8 0 0 0.03s
✅ REPOSITORY git_diff yes no 0.01s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (562ad8e) to head (81611d7).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #94   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          713       713           
=========================================
  Hits           713       713           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann merged commit e9660f7 into main Apr 23, 2024
@lars-reimann lars-reimann deleted the 40-remove-type-hints-from-parameters-results-in-docstrings branch April 23, 2024 16:44
@lars-reimann
Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 0.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove type hints from parameters & results in docstrings

1 participant