Skip to content
This repository was archived by the owner on Nov 23, 2024. It is now read-only.

feat: first iteration of the purity data model and purity analysis#76

Merged
lukarade merged 46 commits intomainfrom
5-data-model-for-purity-information
Mar 30, 2023
Merged

feat: first iteration of the purity data model and purity analysis#76
lukarade merged 46 commits intomainfrom
5-data-model-for-purity-information

Conversation

@lukarade
Copy link
Copy Markdown
Contributor

@lukarade lukarade commented Mar 27, 2023 •
edited
Loading

Closes #5

Summary of Changes

Added the first iteration of the purity data model and the purity analysis. The analysis is capable of analyzing the purity of simple function definitions, as well as functions that interact with files.

Testing Instructions

run test_infer_purity

lukarade and others added 14 commits March 21, 2023 01:08
@lukarade
Added all changes regarding purity-analysis from old branch at "packa…
4d37b1d 
…ge-parser"
@lukarade
PurityInformation now contains ImpurityReasons for impure functions
ba8bc62
@lukarade
Added tests and slightly improved Purity-Analysis
3089adc
@lukarade
Added more tests for generate_purity_information - are failing becaus…
11c2e34 
…e of differences in address
@lars-reimann
chore: WIP
142dcb4
@lukarade
WIP - changes to PurityInformation, added ImpurityCertainty
7aa3521
@lukarade
function ID is now implemented as class, split generate_purtiy_inform…
6285dcb 
…ation function and changed the test to fit the new functions
@lukarade
added Reference(Expression)
d6d4403
@lukarade
added tests for File interaction
a5391ae
@lukarade
WIP: added analysis for builtin function (open), generally improved a…
6a1f2d6 
…nalysis
@lukarade
WIP: added more test for file interaction
150ffea
@lukarade
WIP: Added purity analysis for FileRead and FileWrite with string paths
ea4e2ab
@lukarade
WIP: Improved purity analysis for FileRead and FileWrite with string …
5354c86 
…paths
@lukarade
Merge branch 'main' into 5-data-model-for-purity-information
46951a2
@lukarade lukarade linked an issue Mar 27, 2023 that may be closed by this pull request
Data model for Purity-Information #5
Closed
@lukarade lukarade changed the title Draft: first iteration of the purity data model and purity analysis feat: first iteration of the purity data model and purity analysis Mar 27, 2023
@lars-reimann
Copy link
Copy Markdown
Member

lars-reimann commented Mar 27, 2023 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 6 0 0 0.88s
✅ PYTHON flake8 6 0 0.5s
✅ PYTHON isort 6 0 0 0.27s
✅ PYTHON mypy 6 0 2.37s
✅ PYTHON pylint 6 0 5.32s
✅ REPOSITORY git_diff yes no 0.04s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lars-reimann
Copy link
Copy Markdown
Member

lars-reimann commented Mar 27, 2023

@lukarade I pushed a fix that should resolve some test failures.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2023 •
edited
Loading

Codecov Report

Merging #76 (38a06c8) into main (fd6a0f5) will increase coverage by 0.26%.
The diff coverage is 91.76%.

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   87.66%   87.92%   +0.26%     
==========================================
  Files          83       85       +2     
  Lines        3842     4107     +265     
==========================================
+ Hits         3368     3611     +243     
- Misses        474      496      +22
Impacted Files Coverage Δ
...c/library_analyzer/processing/api/model/_purity.py 88.76% <88.76%> (ø)
...c/library_analyzer/processing/api/_infer_purity.py 93.10% <93.10%> (ø)
src/library_analyzer/processing/api/__init__.py 100.00% <100.00%> (ø)
.../library_analyzer/processing/api/model/__init__.py 100.00% <100.00%> (ø)
src/library_analyzer/utils/_ASTWalker.py 97.22% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

lukarade and others added 17 commits March 28, 2023 14:33
@lukarade
fix: linter fixes
c77c0aa
@lukarade
fix: more linter fixes
6fa23b9
@lukarade
fix: some more linter fixes
2d528f9
@lukarade
fix: last linter fixes
eb115e6
@lukarade @github-actions
style: apply automated linter fixes
0c3504b
@lukarade
feat: improved 'determine_open_mode'
4cf814d
@lukarade
test: added test for 'determine_open_mode'
dad7195
@lukarade
fix: 1 linter fix
0def276
@lukarade
fix: 1 more linter fix
91639d6
@lukarade
fix: linter
b9a7513
@lukarade @github-actions
style: apply automated linter fixes
3a881cf
@lukarade
test: added test_infer_purity_basics with testcases
379dab1
@lukarade
Merge remote-tracking branch 'origin/5-data-model-for-purity-informat…
13e9e00 
…ion' into 5-data-model-for-purity-information
@lukarade
test: added more testcases for code coverage, commented out test_infe…
793ff91 
…r_purity_basics (a much more precise analysis is needed to cover those cases)
@lukarade
Merge branch 'main' into 5-data-model-for-purity-information
4d4fad8
@lukarade
fix: linter fix, removed unused imports
77f82fd
@lukarade @github-actions
style: apply automated linter fixes
92bc461
@lukarade lukarade marked this pull request as ready for review March 29, 2023 17:07
@lukarade lukarade requested a review from a team as a code owner March 29, 2023 17:07
@lars-reimann lars-reimann marked this pull request as draft March 30, 2023 09:05
@lukarade lukarade marked this pull request as ready for review March 30, 2023 14:01
@lukarade
Copy link
Copy Markdown
Contributor Author

lukarade commented Mar 30, 2023 •
edited
Loading

Like we discussed today, I want to close this PR, so it is easier to apply changes to the new branch without having to deal with merge conflicts afterwards. All requested changes will be applied on the new branch: https://github.com/Safe-DS/Library-Analyzer/tree/second-iteration-for-purity-analysis

@lars-reimann
Copy link
Copy Markdown
Member

lars-reimann commented Mar 30, 2023

I want to close this PR

Do you want the PR to be merged or closed without being merged?

@lukarade lukarade merged commit adf27ef into main Mar 30, 2023
@lukarade lukarade deleted the 5-data-model-for-purity-information branch March 30, 2023 15:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@lars-reimann lars-reimann lars-reimann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Data model for Purity-Information

2 participants

@lukarade @lars-reimann