Skip to content

refactor: create abstract base classes Classifier and Regressor for supervised models#66

Merged
lars-reimann merged 5 commits intomainfrom
60-common-superclass-for-models
Mar 23, 2023
Merged

refactor: create abstract base classes Classifier and Regressor for supervised models#66
lars-reimann merged 5 commits intomainfrom
60-common-superclass-for-models

Conversation

@lars-reimann
Copy link
Copy Markdown
Member

@lars-reimann lars-reimann commented Mar 23, 2023

Closes #60.

Summary of Changes

  • Create abstract base class Classifier and make all current classifiers subclasses of it
  • Create abstract base class Regressor and make all current regressors subclasses of it.

@lars-reimann lars-reimann linked an issue Mar 23, 2023 that may be closed by this pull request
Common superclass for models #60
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2023 •
edited
Loading

Codecov Report

Merging #66 (30e2102) into main (db6dbd7) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   91.48%   91.73%   +0.24%     
==========================================
  Files          44       46       +2     
  Lines        1128     1161      +33     
==========================================
+ Hits         1032     1065      +33     
  Misses         96       96
Impacted Files Coverage Δ
src/safeds/ml/classification/__init__.py 100.00% <100.00%> (ø)
src/safeds/ml/classification/_ada_boost.py 100.00% <100.00%> (ø)
src/safeds/ml/classification/_classifier.py 100.00% <100.00%> (ø)
src/safeds/ml/classification/_decision_tree.py 100.00% <100.00%> (ø)
...lassification/_gradient_boosting_classification.py 100.00% <100.00%> (ø)
...c/safeds/ml/classification/_k_nearest_neighbors.py 100.00% <100.00%> (ø)
...c/safeds/ml/classification/_logistic_regression.py 100.00% <100.00%> (ø)
src/safeds/ml/classification/_random_forest.py 100.00% <100.00%> (ø)
src/safeds/ml/regression/__init__.py 100.00% <100.00%> (ø)
src/safeds/ml/regression/_ada_boost.py 100.00% <100.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lars-reimann
Copy link
Copy Markdown
Member Author

lars-reimann commented Mar 23, 2023 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 19 0 0 0.73s
✅ PYTHON flake8 19 0 0.52s
✅ PYTHON isort 19 0 0 0.26s
✅ PYTHON mypy 19 0 2.01s
✅ PYTHON pylint 19 0 2.3s
✅ REPOSITORY git_diff yes no 0.03s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lars-reimann lars-reimann force-pushed the 60-common-superclass-for-models branch from 75cdbdd to e26f20a Compare March 23, 2023 21:11
@lars-reimann lars-reimann merged commit ec27236 into main Mar 23, 2023
@lars-reimann lars-reimann deleted the 60-common-superclass-for-models branch March 23, 2023 21:17
@lars-reimann
Copy link
Copy Markdown
Member Author

lars-reimann commented Mar 24, 2023

🎉 This PR is included in version 0.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released Included in a release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Common superclass for models

1 participant

@lars-reimann