Skip to content

refactor: standardize image tests#376

Merged
sibre28 merged 15 commits intomainfrom
369-standardize-image-tests
Jun 23, 2023
Merged

refactor: standardize image tests#376
sibre28 merged 15 commits intomainfrom
369-standardize-image-tests

Conversation

@sibre28
Copy link
Copy Markdown
Contributor

@sibre28 sibre28 commented Jun 23, 2023 •
edited by Marsmaennchen221
Loading

Closes #369.

Summary of Changes

Changed functionality of Image transformation methods to use a deepCopy instead of a bytestream to create a copy of the image.
Changed tests to only test one file format.

@sibre28 sibre28 requested a review from a team as a code owner June 23, 2023 07:41
@sibre28 sibre28 linked an issue Jun 23, 2023 that may be closed by this pull request
Standardize Image Tests #369
Closed
@lars-reimann
Copy link
Copy Markdown
Member

lars-reimann commented Jun 23, 2023 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 2 0 0 0.72s
✅ PYTHON mypy 2 0 2.21s
✅ PYTHON ruff 2 0 0 0.02s
✅ REPOSITORY git_diff yes no 0.0s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 23, 2023 •
edited
Loading

Codecov Report

Merging #376 (56291c0) into main (9073f04) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #376   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         2382      2348   -34     
=========================================
- Hits          2382      2348   -34
Impacted Files Coverage Δ
src/safeds/data/image/containers/_image.py 100.00% <100.00%> (ø)

@Marsmaennchen221 Marsmaennchen221 changed the title refactor: 369 standardize image tests refactor: standardize image tests Jun 23, 2023
patrikguempel
patrikguempel reviewed Jun 23, 2023
View reviewed changes
@sibre28 @patrikguempel
Update tests/safeds/data/image/containers/test_image.py
e5b8560 
Co-authored-by: patrikguempel <patrikguempel@gmail.com>
Marsmaennchen221
Marsmaennchen221 requested changes Jun 23, 2023
View reviewed changes
sibre28 and others added 3 commits June 23, 2023 10:36
@sibre28 @Marsmaennchen221
Apply suggestions from code review
275388d 
Co-authored-by: Alexander <47296670+Marsmaennchen221@users.noreply.github.com>
@sibre28 @Marsmaennchen221
Update tests/safeds/data/image/containers/test_image.py
57403e2 
Co-authored-by: Alexander <47296670+Marsmaennchen221@users.noreply.github.com>
@sibre28
deleted unused file
e602b19
@sibre28 sibre28 requested a review from Marsmaennchen221 June 23, 2023 08:46
@sibre28
Copy link
Copy Markdown
Contributor Author

sibre28 commented Jun 23, 2023

LGTM

@sibre28 sibre28 merged commit 8fe40fa into main Jun 23, 2023
@sibre28 sibre28 deleted the 369-standardize-image-tests branch June 23, 2023 10:57
@sibre28 sibre28 mentioned this pull request Jun 25, 2023
Closed
@lars-reimann
Copy link
Copy Markdown
Member

lars-reimann commented Jun 30, 2023

🎉 This PR is included in version 0.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Marsmaennchen221 Marsmaennchen221 Marsmaennchen221 approved these changes

+1 more reviewer

@patrikguempel patrikguempel patrikguempel left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released Included in a release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Standardize Image Tests

6 participants

@sibre28 @lars-reimann @Marsmaennchen221 @patrikguempel @PhilipGutberlet @megalinter-bot