Support reparsing of MPF-processed outputs#896
Support reparsing of MPF-processed outputs#896mnadareski merged 10 commits intoSabreTools:masterfrom Deterous:master
Conversation
| basePath = Path.Combine(outputDirectory, basePath); | ||
|
|
||
| // Extract sidecar from archive, if it is zipped | ||
| #if NET462_OR_GREATER || NETCOREAPP |
There was a problem hiding this comment.
It feels odd to have both the single-file extraction in each processor alongside the extraction of the entire log zip, if needed. Is there a case where the code will get into the processor and it either hasn't come from a normal dumping run or Check invocation?
There was a problem hiding this comment.
single file is needed first for media detection
| /// <param name="outputFilename">Output filename to use as the base path</param> | ||
| /// <remarks>Assumes filename has an extension</remarks> | ||
| #if NET462_OR_GREATER || NETCOREAPP | ||
| public void ExtractFromLogs(MediaType? mediaType, string? outputDirectory, string outputFilename) |
There was a problem hiding this comment.
There's something odd with the order of operations in this method. It looks like it would work correctly, but it seems like it's doing things it doesn't need to.
| return; | ||
|
|
||
| // Extract all found output files from the archive | ||
| foreach (var outputFile in outputFiles) |
There was a problem hiding this comment.
I think instead of trying to be picky about what's extracted, we can just extract the whole thing in one go. I would be open to hearing what the rationale was behind using only the list of output files, though.
There was a problem hiding this comment.
This means that there will never be any files left in the folder that are not re-zipped
|
The failing test is |
Unzips all detected output files in an existing log zip, so that a 2nd log zip can be created.
Fixes #844
Also tweaks the required redumper files: fulltoc and scram no longer required.
Some drives cant do fulltoc, and we should support case where dumper already deleted scram.
Also fixes Check UI issue where message about missing files is eaten.