Remove SkipMediaTypeDetection option, cleanup options window#895
Merged
mnadareski merged 3 commits intoSabreTools:masterfrom Sep 26, 2025
Deterous:master
Merged
Remove SkipMediaTypeDetection option, cleanup options window#895mnadareski merged 3 commits intoSabreTools:masterfrom Deterous:master
mnadareski merged 3 commits intoSabreTools:masterfrom
Deterous:master
Conversation
mnadareski
reviewed
Sep 26, 2025
mnadareski
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SkipMediaTypeDetectionoption is now mostly obsolete, so this PR removes it.Unlike long ago, MPF no longer uses the old third party library (no chance of freezing the UI so there is no essential need for the option).
And as of recently, only DIC execution context cares about the media type, so I have replaced the option with a check against Internal Program. Media type detection now runs only when DIC is selected.
Additionally, a couple of minor UI fixes have been made in the Options window.