Update redumper, MPF options, SS sanity check#854
Merged
mnadareski merged 12 commits intoSabreTools:masterfrom May 30, 2025
Deterous:master
Merged
Update redumper, MPF options, SS sanity check#854mnadareski merged 12 commits intoSabreTools:masterfrom Deterous:master
mnadareski merged 12 commits intoSabreTools:masterfrom
Deterous:master
Conversation
Member
Deterous
commented
May 30, 2025
- Updates redumper to build 597 (New: Drive detection rework, XGD3 SS repairing)
- Adds new redumper flags (ListRecommendedDrives, ListAllDrives, Rings)
- Remove BE_CDDA as a read method
- Redumper flags reordering
- Improve redumper options
- Simplify MPF's retries and plextor leadin retries options
- Adds a DriveType option to MPF (extends Generic drive option to include PLEXTOR and LG_ASU* types)
- Extra SS sanity check to prevent bad SS files from being created/hashed (.security file is still kept)
mnadareski
reviewed
May 30, 2025
| /// <summary> | ||
| /// Drive type option | ||
| /// </summary> | ||
| public enum DriveType |
Collaborator
There was a problem hiding this comment.
Nitpick: Please keep the enums in alphabetical order
| using Xunit; | ||
| using RedumperReadMethod = MPF.ExecutionContexts.Redumper.ReadMethod; | ||
| using RedumperSectorOrder = MPF.ExecutionContexts.Redumper.SectorOrder; | ||
| using RedumperDriveType = MPF.ExecutionContexts.Redumper.DriveType; |
Collaborator
There was a problem hiding this comment.
Nitpick: Alphabetical using mappings please
| using RedumperReadMethod = MPF.ExecutionContexts.Redumper.ReadMethod; | ||
| using RedumperSectorOrder = MPF.ExecutionContexts.Redumper.SectorOrder; | ||
|
|
||
| using RedumperDriveType = MPF.ExecutionContexts.Redumper.DriveType; |
| /// </summary> | ||
| /// <param name="order">RedumperDriveType value to convert</param> | ||
| /// <returns>String representing the value, if possible</returns> | ||
| public static string LongName(this RedumperDriveType? type) |
Collaborator
There was a problem hiding this comment.
Nitpick: Same for both methods here
| using MPF.Frontend.ComboBoxItems; | ||
| using RedumperReadMethod = MPF.ExecutionContexts.Redumper.ReadMethod; | ||
| using RedumperSectorOrder = MPF.ExecutionContexts.Redumper.SectorOrder; | ||
| using RedumperDriveType = MPF.ExecutionContexts.Redumper.DriveType; |
Collaborator
There was a problem hiding this comment.
Nitpick: You guessed it...
Comment on lines
+435
to
+436
| <Label/> | ||
| <!-- Empty label for padding --> |
Collaborator
There was a problem hiding this comment.
This formatting got messed up at some point, but the comment should be on the same line as the empty label.
mnadareski
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.