Bring list to parity with Redump known types#2
Merged
3 commits merged intoSabreTools:masterfrom May 14, 2018
mnadareski:master
Merged
Bring list to parity with Redump known types#23 commits merged intoSabreTools:masterfrom mnadareski:master
3 commits merged intoSabreTools:masterfrom
mnadareski:master
Conversation
This change adds all remaining consoles and disc-based devices that are currently listed in Redump as valid devices. This also does some minor renames and splits that bring this to parity as well. One minor TODO note was added possibly for future ease-of-use for dumping IBM PC software.
Collaborator
Author
|
One additional suggestion: with the TODO that I added, I realize that detecting the protection is not something that can be done easily through a script, so I would recommend having a single set of flags that would cover the IBM PC cases no matter what. Because dumping a disc with no SecuROM or something with the same flags as one that does will not affect how that first disc is dumped. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds all remaining consoles and disc-based devices that are currently listed in Redump as valid devices. This also does some minor renames and splits that bring this to parity as well. One minor TODO note was added possibly for future ease-of-use for dumping IBM PC software.
The second commit disables application signing because no certificate is in the repository and nobody but the original author would be able to build this from source otherwise.