Skip to content

[Problem] Audio CD: Perfect Audio Offset of +0 incorrectly reported for all instances of Perfect Audio Offset #824

@mictlantecuhtle

Description

@mictlantecuhtle

Version
What version are you using?

Build
What runtime version are you using?

  • .NET 9.0

Describe the issue
Wherever the phrase "Perfect Audio Offset applied" appears in redumper logs, MPF incorrectly adds a line in !submissionInfo.txt to say <b>Ring Perfect Audio Offset</b>: +0

This line should only be added when BOTH "Perfect Audio Offset applied" AND "disc write offset: +0" appear in the logs.

From examination of various sets of dump logs, this behaviour occurs with both positive and negative offsets.

To Reproduce
Steps to reproduce the behavior:

  1. Dump an Audio CD with either a positive or negative offset.
  2. Check the redumper log to verify that e.g. ""Perfect Audio Offset applied" and "disc write offset: -12" appear
  3. Check the !submissionInfo.txt file to verify that the line <b>Ring Perfect Audio Offset</b>: +0 appears

Expected behavior
The line <b>Ring Perfect Audio Offset</b>: +0 should only be added when BOTH "Perfect Audio Offset applied" AND "disc write offset: +0" appear in the logs.

122041_Foil1332 (+37 offset).zip

121855_Maddog (-12 offset).zip

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions