templates/cephadm/deployment_day_2: fix NFS cluster create command#612
templates/cephadm/deployment_day_2: fix NFS cluster create command#612mgfritch merged 1 commit intoSUSE:masterfrom
Conversation
There was a problem hiding this comment.
LGTM
Just a note, in pacific the type (cephfs) argument has been removed again [1], so we will need to change this back (unless there is a way to make it work for both cases).
[1] ceph/ceph#40411
|
@trociny Thanks! My guess is that ceph/ceph#37600 won't get backported to octopus, so ceph/ceph#40411 won't get backported to octopus, either. And yes there is a way to conditionalize octopus/pacific here. I have updated the PR - please have another look? |
mgfritch
left a comment
There was a problem hiding this comment.
@trociny Thanks! My guess is that ceph/ceph#37600 won't get backported to octopus, so ceph/ceph#40411 won't get backported to octopus, either.
the plan is to not backport these PRs to Octopus and try to keep the CLI stable from Pacific forward ...
At some point, upstream obviously changed the syntax of the "ceph nfs cluster create" command in octopus, thereby breaking "sesdev create pacific" and "sesdev create ses7". Later, this syntax change got reverted [1], but since this revert was made possible by a big feature [2], so far it has been backported only to pacific [3] [1] ceph/ceph#40411 [2] ceph/ceph#37600 [3] ceph/ceph#41005 Fixes: SUSE#611 Signed-off-by: Nathan Cutler <ncutler@suse.com>
At some point, upstream obviously changed the syntax of the "ceph nfs cluster
create" command in octopus, thereby breaking "sesdev create pacific" and "sesdev
create ses7".
Later, this syntax change got reverted [1], but since this revert was made
possible by a big feature [2], so far it has been backported only to pacific [3]
[1] ceph/ceph#40411
[2] ceph/ceph#37600
[3] ceph/ceph#41005
Fixes: #611
Signed-off-by: Nathan Cutler ncutler@suse.com