Tests: Update test_0003_ad_parameters_junk_domain_invalid_keytab#8350
Merged
jakub-vavra-cz merged 1 commit intoSSSD:masterfrom Jan 13, 2026
Merged
Tests: Update test_0003_ad_parameters_junk_domain_invalid_keytab#8350jakub-vavra-cz merged 1 commit intoSSSD:masterfrom
jakub-vavra-cz merged 1 commit intoSSSD:masterfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the test test_0003_ad_parameters_junk_domain_invalid_keytab to account for a change in sssd's behavior when an invalid keytab is present. The assertion is correctly modified to check for one of two possible log messages, reflecting both the old and new code paths. The change is clear, well-commented, and appropriate. I have reviewed the changes and found no issues.
shridhargadekar
approved these changes
Jan 13, 2026
Change 684e568 added a code path that sets the realm to the AD domain name if the keytab is invalid. This changes the expected log message "Selected realm:" on sssd 2.12+. Reviewed-by: Shridhar Gadekar <sgadekar@redhat.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change 684e568 added a code path that sets the realm to the AD domain name if the keytab is invalid. This changes the expected log message "Selected realm:" on sssd 2.12+.