sysdb: do not treat missing id-override as an error#8325
Merged
alexey-tikhonov merged 1 commit intoSSSD:masterfrom Jan 6, 2026
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request correctly addresses the issue of treating a missing id-override as an error. The change in sysdb_search_user_by_upn_with_view_res ensures that an ENOENT return from sysdb_add_overrides_to_object is handled as a non-error case, which is the correct behavior when a user exists but has no overrides. The implementation is simple and effective. I have no further comments.
alexey-tikhonov
approved these changes
Jan 5, 2026
This was referenced Jan 5, 2026
In sysdb_search_user_by_upn_with_view_res() sysdb_add_overrides_to_object() can return ENOENT if there is no id-override for the given user. This is expected and should not be treated as an error. Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
Contributor
d56d56d to
d53a4e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In sysdb_search_user_by_upn_with_view_res()
sysdb_add_overrides_to_object() can return ENOENT if there is no id-override for the given user. This is expected and should not be treated as an error.