Unpatched 'krb5_child' cap-set-id tests#8314
Closed
alexey-tikhonov wants to merge 1 commit intoSSSD:masterfrom
Closed
Unpatched 'krb5_child' cap-set-id tests#8314alexey-tikhonov wants to merge 1 commit intoSSSD:masterfrom
alexey-tikhonov wants to merge 1 commit intoSSSD:masterfrom
Conversation
(cherry picked from commit a4a7b3d)
There was a problem hiding this comment.
Code Review
This pull request removes the cap_setuid and cap_setgid capabilities from the krb5_child binary in both the Makefile.am and the RPM spec file. My review has found that this change is incorrect and will break critical functionality. The krb5_child process requires these capabilities to switch to a user's identity for operations like creating credential caches. I have added critical comments to both changed files with details and suggestions to revert these changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.