cherry-pick: 8120 to 2.11 - Migrate missing tests to new framework#8290
Merged
thalman merged 1 commit intoSSSD:sssd-2-11from Dec 10, 2025
Merged
cherry-pick: 8120 to 2.11 - Migrate missing tests to new framework#8290thalman merged 1 commit intoSSSD:sssd-2-11from
thalman merged 1 commit intoSSSD:sssd-2-11from
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates several tests from the old integ/test_ldap.py framework to the new system test framework, creating a new test_nss.py file. The migration is a good step forward. I've found a couple of issues in the newly added tests: one is an incorrect type hint that restricts a test's applicability, and the other is an incomplete test that doesn't fully verify the caching behavior it's supposed to. I've provided specific suggestions to address these points. Additionally, a related test was refactored from test_authentication.py to test_nss.py, which is a logical improvement.
thalman
approved these changes
Dec 10, 2025
This PR implements tests from integ/test_ldap.py to new system tests Reviewed-by: Dan Lavu <dlavu@redhat.com> Reviewed-by: Jakub Vávra <jvavra@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com>
Contributor
d268969 to
b9a248e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements tests from integ/test_ldap.py to new system tests
Reviewed-by: Dan Lavu dlavu@redhat.com
Reviewed-by: Jakub Vávra jvavra@redhat.com