Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the ent_test.py file, which contains integration tests that are reportedly flaky and causing CI failures. Given that these tests are for internal tooling and the entire integration test suite is planned for removal, deleting this file is a reasonable step to improve CI stability and clean up the codebase. The change is straightforward and I see no issues with it.
alexey-tikhonov
approved these changes
Dec 9, 2025
These tests randomly fails, making CI red. They do not test SSSD, just internal intg tests tooling and since the intg tests are going away, it does not make sense to spend time on it or even mark it as flaky. Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
Contributor
This was referenced Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests randomly fails, making CI red. They do not test SSSD, just
internal intg tests tooling and since the intg tests are going away,
it does not make sense to spend time on it or even mark it as flaky.